fix: make replace optional in type declaration and update JSDoc#137
Merged
remarkablemark merged 2 commits intomasterfrom Feb 8, 2020
Merged
fix: make replace optional in type declaration and update JSDoc#137remarkablemark merged 2 commits intomasterfrom
replace optional in type declaration and update JSDoc#137remarkablemark merged 2 commits intomasterfrom
Conversation
And update the return types See #134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Fixes
index.d.tsby makingreplaceproperty optional in the 2nd argument object.Also, updated and fixed incorrect JSDoc in
lib/dom-to-react.js.What is the current behavior?
If a 2nd argument is specified,
replaceis required so instead of:Developers are forced to:
See #134
What is the new behavior?
Developers are no longer forced to satisfy the type requirements. See above.
Checklist: