Skip to content

fix(package): set dependency @types/react to 17 or 18#1321

Merged
remarkablemark merged 1 commit intomasterfrom
fix/package
Feb 19, 2024
Merged

fix(package): set dependency @types/react to 17 or 18#1321
remarkablemark merged 1 commit intomasterfrom
fix/package

Conversation

@remarkablemark
Copy link
Copy Markdown
Owner

What is the motivation for this pull request?

fix(package): set dependency @types/react to 17 or 18

Fixes #1320

What is the current behavior?

@types/react is set to 18.2.55

What is the new behavior?

@types/react is set to 17 || 18

Checklist:

@remarkablemark remarkablemark added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 19, 2024
@remarkablemark remarkablemark self-assigned this Feb 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 9.17 KB (0%) 184 ms (0%) 26 ms (+235.2% 🔺) 209 ms

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (245e8ba) 100.00% compared to head (0605477) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1321   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          151       151           
  Branches        49        49           
=========================================
  Hits           151       151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remarkablemark remarkablemark merged commit 688a3a1 into master Feb 19, 2024
@remarkablemark remarkablemark deleted the fix/package branch February 19, 2024 02:16
@remarkablemark
Copy link
Copy Markdown
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 5.1.5 - multiple versions of @types/react causes typescript build errors

1 participant