fix(esm): fix any type#1317
Merged
remarkablemark merged 4 commits intoremarkablemark:masterfrom Feb 16, 2024
mrlika:patch-1
Merged
fix(esm): fix any type#1317remarkablemark merged 4 commits intoremarkablemark:masterfrom mrlika:patch-1
remarkablemark merged 4 commits intoremarkablemark:masterfrom
mrlika:patch-1
Conversation
remarkablemark
requested changes
Feb 15, 2024
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
Can you fix the lint error?
npm run lint:fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1317 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 151 151
Branches 49 49
=========================================
Hits 151 151 ☔ View full report in Codecov by Sentry. |
remarkablemark
approved these changes
Feb 16, 2024
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
anytype of export:What is the motivation for this pull request?
Import:
Results in
anytypedHTMLReactParserreference that is disallowed by linters in many projects:What is the current behavior?
The export is not typed (i.e.
any).What is the new behavior?
The export type is fixed to the expected one.
Checklist: