Skip to content

fix(esm): fix exported types#1310

Merged
remarkablemark merged 2 commits intomasterfrom
fix/esm
Feb 12, 2024
Merged

fix(esm): fix exported types#1310
remarkablemark merged 2 commits intomasterfrom
fix/esm

Conversation

@remarkablemark
Copy link
Copy Markdown
Owner

What is the motivation for this pull request?

fix(esm): fix exported types

Fixes #1305

What is the current behavior?

  1. ESM types not working
  2. Using global JSX namespace

What is the new behavior?

  1. ESM types working
  2. Using React.JSX

Checklist:

@remarkablemark remarkablemark added the bug Something isn't working label Feb 12, 2024
@remarkablemark remarkablemark self-assigned this Feb 12, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a1abba) 100.00% compared to head (a25f41c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1310   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          151       151           
  Branches        49        49           
=========================================
  Hits           151       151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 9.17 KB (0%) 184 ms (0%) 21 ms (+176.41% 🔺) 205 ms

@remarkablemark remarkablemark merged commit 8432faf into master Feb 12, 2024
@remarkablemark remarkablemark deleted the fix/esm branch February 12, 2024 21:44
@remarkablemark
Copy link
Copy Markdown
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolution error when using TypeScript with moduleResolution set to node16 or nodenext

1 participant