fix(esm): make ESM exports explicit in index.mjs and utilities.mjs#1229
Merged
remarkablemark merged 2 commits intomasterfrom Dec 18, 2023
Merged
fix(esm): make ESM exports explicit in index.mjs and utilities.mjs#1229remarkablemark merged 2 commits intomasterfrom
remarkablemark merged 2 commits intomasterfrom
Conversation
Don't throw a commitlint error for: ``` footer's lines must not be longer than 100 characters ```
Fixes #1228 Vite fails with the error: ``` Uncaught SyntaxError: The requested module '/@fs/Users/.../node_modules/.vite/app/deps/html-react-parser.js?v=719515aa' does not provide an export named 'Element' (at list.tsx:6:31) ```
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Fixes #1228
Caused by #1226
What is the current behavior?
Vite fails with the error:
*exports in ESM filesWhat is the new behavior?
Vite does not error
Named exports in ESM files
Checklist: