Skip to content

fix(esm): support vite bundler#1135

Merged
remarkablemark merged 1 commit intomasterfrom
fix/esm
Oct 30, 2023
Merged

fix(esm): support vite bundler#1135
remarkablemark merged 1 commit intomasterfrom
fix/esm

Conversation

@remarkablemark
Copy link
Copy Markdown
Owner

What is the motivation for this pull request?

fix(esm): support vite bundler

Fixes #1132

What is the current behavior?

Running npx vite build && npx vite preview throws an error in the browser:

TypeError: rm is not a function

What is the new behavior?

Fix the default export so that vite builds properly

Checklist:

@remarkablemark remarkablemark added the bug Something isn't working label Oct 30, 2023
@remarkablemark remarkablemark self-assigned this Oct 30, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1135 (bad1e4c) into master (0b70d89) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          152       152           
  Branches        50        50           
=========================================
  Hits           152       152           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 10.2 KB (0%) 205 ms (0%) 21 ms (+108.3% 🔺) 225 ms

@remarkablemark remarkablemark merged commit ac73d24 into master Oct 30, 2023
@remarkablemark remarkablemark deleted the fix/esm branch October 30, 2023 23:47
@remarkablemark
Copy link
Copy Markdown
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

version 5.0.1 cannot work with vite

1 participant