Merged
Conversation
For the client parser, when the first element of the HTML string has attributes, the regex will improperly capture everything and make the tag name invalid. The fix is to ensure only the tag name is matched and whitespace is trimmed. Fixes #23
Confirm that for the client parser, if the first HTML element has attributes, it should properly match only the tag name and no longer throw an error. Issue #23
remarkablemark
added a commit
that referenced
this pull request
Sep 27, 2016
- Update README (#17 and #21): - Improve documentation of `replace` option with the help of @poacher2k - Tidy and reword some parts - Use webpack to build UMD bundle (#22) - Build to `./dist/` directory before publish - Fix regex bug on client parser (#24) - Add test for `window.DOMParser`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23
Tasks:
window.DOMParserDOMParser