Merged
Conversation
Follow standard config: https://webpack.github.io/docs/configuration.html Export to `./dist/html-react-parser.min.js` Specify `react` in "externals": https://github.com/webpack/webpack/tree/master/examples/externals
npm scripts: - build (unminified UMD bundle) - build-min (minified UMD bundle) `webpack.config.js`: - Remove "entry" and "output.filename" now that paths are passed via CLI
Remove branches where `process.env.NODE_ENV !== "production"` especially for React.
Build the unminified and minified client-side bundles before publish.
remarkablemark
added a commit
that referenced
this pull request
Sep 27, 2016
- Update README (#17 and #21): - Improve documentation of `replace` option with the help of @poacher2k - Tidy and reword some parts - Use webpack to build UMD bundle (#22) - Build to `./dist/` directory before publish - Fix regex bug on client parser (#24) - Add test for `window.DOMParser`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an improvement of #6 and #9, let webpack handle building the UMD bundle. Build inspired by react-router.
The bundle will be generated in the
./dist/directory ashtml-react-parser.jsandhtml-react-parser.min.js.Tasks:
build: Builds development/unminified bundlebuild-min: Builds production/minified bundleprepublish: Runsbuildandbuild-minbefore publishwebpack@1.13.2and createwebpack.config.jsdistto.gitignore