-
-
Notifications
You must be signed in to change notification settings - Fork 140
Comparing changes
Open a pull request
base repository: remarkablemark/html-react-parser
base: v0.0.3
head repository: remarkablemark/html-react-parser
compare: v0.0.4
- 16 commits
- 10 files changed
- 2 contributors
Commits on Aug 25, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 886e1d9 - Browse repository at this point
Copy the full SHA 886e1d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2a9655 - Browse repository at this point
Copy the full SHA e2a9655View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2cb9f1 - Browse repository at this point
Copy the full SHA d2cb9f1View commit details -
Add directory to: - .gitignore - .npmignore
Configuration menu - View commit details
-
Copy full SHA for e44e739 - Browse repository at this point
Copy the full SHA e44e739View commit details -
Merge pull request #12 from remarkablemark/coveralls
Setup Istanbul and Coveralls for coverage reporting
Configuration menu - View commit details
-
Copy full SHA for dadbac7 - Browse repository at this point
Copy the full SHA dadbac7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 194b5f6 - Browse repository at this point
Copy the full SHA 194b5f6View commit details -
Merge pull request #13 from remarkablemark/badges
Update README with Travis and Coveralls badges
Configuration menu - View commit details
-
Copy full SHA for 23bd928 - Browse repository at this point
Copy the full SHA 23bd928View commit details
Commits on Aug 26, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 91f5340 - Browse repository at this point
Copy the full SHA 91f5340View commit details -
Add badges from NodeICO, NPM, and David to README
Display npm package details: - https://nodei.co Display npm version: - http://shields.io Display npm dependencies status: - https://david-dm.org Misc: https://yanni4night.github.io/badge.html
Configuration menu - View commit details
-
Copy full SHA for 6cd5ea6 - Browse repository at this point
Copy the full SHA 6cd5ea6View commit details -
Merge pull request #15 from remarkablemark/readme
Fix typo and add more badges to README
Configuration menu - View commit details
-
Copy full SHA for 15d92ab - Browse repository at this point
Copy the full SHA 15d92abView commit details
Commits on Aug 29, 2016
-
Make sure
props.childrenis null for void elements like <img>The error came from the fact that `props.children` would always be at minimum an empty array `[]`. This causes the following error: ```js ReactDOMServer.renderToString( Parser('<img />') ); // Invariant Violation: img is a void element tag and must neither // have `children` nor use `dangerouslySetInnerHTML`. ``` The fix was to make `props.children` equal to `null` unless there were actually more DOM nodes inside the array. Add tests to confirm that void HTML element tags no longer throws an error.Configuration menu - View commit details
-
Copy full SHA for 2a12730 - Browse repository at this point
Copy the full SHA 2a12730View commit details -
Refactor tests by moving
renderfunction into helpers`render` is an alias for `ReactDOMServer.renderToStaticMarkup` Update `render` function to check that the first argument is a valid React element; otherwise, throw an error.
Configuration menu - View commit details
-
Copy full SHA for db39cf6 - Browse repository at this point
Copy the full SHA db39cf6View commit details -
Update
replacemethod with additionalkeyparameterThe `replace` method now has 2 parameters: 1. domNode - The object describing the DOM node. 2. key - The array index. The `key` parameter was added because if the element had siblings, then the replaced React element should have a unique "key" prop or else React will display a warning: > Warning: Each child in an array or iterator should have a > unique "key" prop. See https://fb.me/react-warning-keys for > more information. Updated the mock data for complex html and used the `key` parameter to fix a test.
Configuration menu - View commit details
-
Copy full SHA for 226cc15 - Browse repository at this point
Copy the full SHA 226cc15View commit details -
Update README with better documentation on
replacemethodAdd new parameter `key` and update examples.
Configuration menu - View commit details
-
Copy full SHA for e3c91ac - Browse repository at this point
Copy the full SHA e3c91acView commit details -
Merge pull request #16 from remarkablemark/bug-void-element
Fix void element bug and add `key` parameter to `replace` method
Configuration menu - View commit details
-
Copy full SHA for 20177ee - Browse repository at this point
Copy the full SHA 20177eeView commit details -
- Fix void element bug (#14) - Void elements like <img> should not have any children (even an empty array `[]` counts as children) - Pass `key` to the `replace` method as the second parameter - Prevent React "key" warning - Update tests, mocks, and helpers - Update README with update on `replace` method
Configuration menu - View commit details
-
Copy full SHA for ddd289b - Browse repository at this point
Copy the full SHA ddd289bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.0.3...v0.0.4