Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: remarkablemark/html-react-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.2
Choose a base ref
...
head repository: remarkablemark/html-react-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.3
Choose a head ref
  • 10 commits
  • 10 files changed
  • 2 contributors

Commits on Aug 24, 2016

  1. Refactor HTML to DOM modules and environment detection logic 

    Move the client/server environment detection logic to the entry
file.

Rename `lib/html-to-dom.js` to `lib/html-to-dom-server.js` and
move the client-side parsing logic to `lib/html-to-dom-client.js`.
`lib/html-to-dom-server.js` will only contain the server-side
logic.

Fix and update the tests.
    @remarkablemark
    remarkablemark committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    cfeaea5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #5 from remarkablemark/refactor-html-to-dom 

    Refactor HTML to DOM modules and environment detection logic
    @remarkablemark
    remarkablemark authored Aug 24, 2016
    Configuration menu
    Copy the full SHA
    58e81cc View commit details
    Browse the repository at this point in the history

  3. Ignore lib/html-to-dom-server when bundling for the browser 

    Also, fix the require path for `html-to-dom-client` module in the
entry file `index.js`.
    @remarkablemark
    remarkablemark committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    3195109 View commit details
    Browse the repository at this point in the history

  4. Make package UMD (Univeral Module Definition) compatible 

    Wrap main logic so that it can be loaded by CommonJS (node and
bundlers like webpack), AMD (RequireJS), and browser script.

UMD template:
https://github.com/ForbesLindesay/umd/blob/master/template.js
    @remarkablemark
    remarkablemark committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    38352d9 View commit details
    Browse the repository at this point in the history

  5. Disable eslint warnings in UMD module index.js 

    Also add `.npmignore` file to `.npmignore`
    @remarkablemark
    remarkablemark committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    f109b58 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #9 from remarkablemark/umd 

    UMD compatibility
    @remarkablemark
    remarkablemark authored Aug 24, 2016
    Configuration menu
    Copy the full SHA
    15cc84c View commit details
    Browse the repository at this point in the history

  7. Fix HTML to DOM client parser 

    `DOMParser` was nesting certain elements (e.g., div) in `<html>`
and `body` so formatting the child nodes of document gave incorrect
results.

Update logic so that the correct nodes are parsed and formatted.
    @remarkablemark
    remarkablemark committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    80ca2e2 View commit details
    Browse the repository at this point in the history

  8. Throw an error if the first argument for the parser is not a string 

    This is to give the user gets feedback if the first argument is
invalid. Also, add tests to confirm behavior.
    @remarkablemark
    remarkablemark committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    8cd62a8 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #10 from remarkablemark/html-to-dom-client 

    Fix HTML to DOM client parser
    @remarkablemark
    remarkablemark authored Aug 24, 2016
    Configuration menu
    Copy the full SHA
    becc168 View commit details
    Browse the repository at this point in the history

  10. Bump version to 0.0.3 

    - Make package compatible with UMD (Universal Module Definition)
- Fix bug in client parser (regarding HTML to DOM logic)
- Throw error if first argument for parser is not a string
- Refactor code and environment detection logic
    @remarkablemark
    remarkablemark committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    ab2b86e View commit details
    Browse the repository at this point in the history
Loading