Fix type re-export#612
Merged
remarkablemark merged 1 commit intoremarkablemark:masterfrom Dec 19, 2023
Merged
Conversation
remarkablemark
approved these changes
Dec 19, 2023
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
Thanks for the PR @DreierF! LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
=======================================
Coverage 89.62% 89.62%
=======================================
Files 7 7
Lines 135 135
Branches 30 30
=======================================
Hits 121 121
Misses 6 6
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
When importing html-dom-parser 5.0.5 from Typescript with
verbatimModuleSyntaxenabled the build fails with:What is the current behavior?
Typescript fails
What is the new behavior?
Typescript accepts the input
Checklist: