Skip to content

refactor: migrate to TypeScript#527

Merged
remarkablemark merged 1 commit intomasterfrom
refactor/typescript
Oct 16, 2023
Merged

refactor: migrate to TypeScript#527
remarkablemark merged 1 commit intomasterfrom
refactor/typescript

Conversation

@remarkablemark
Copy link
Copy Markdown
Owner

@remarkablemark remarkablemark commented Oct 16, 2023

What is the motivation for this pull request?

refactor: migrate to TypeScript

BREAKING CHANGE: CommonJS imports require the .default key.

Is depended on by remarkablemark/html-react-parser#1000

What is the current behavior?

Vanilla JavaScript

What is the new behavior?

TypeScript

Checklist:

@remarkablemark remarkablemark added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 16, 2023
@remarkablemark remarkablemark self-assigned this Oct 16, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-dom-parser.min.js 2.25 KB (-41.28% 🔽) 45 ms (-41.28% 🔽) 62 ms (+194.6% 🔺) 107 ms

BREAKING CHANGE: CommonJS imports require the `.default` key.
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2023

Codecov Report

Merging #527 (5915b08) into master (e40ccd8) will decrease coverage by 6.82%.
The diff coverage is 87.59%.

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
- Coverage   94.40%   87.59%   -6.82%     
==========================================
  Files           7        7              
  Lines         143      137       -6     
  Branches        0       30      +30     
==========================================
- Hits          135      120      -15     
- Misses          8        9       +1     
- Partials        0        8       +8     
Files Coverage Δ
src/client/constants.ts 100.00% <100.00%> (ø)
src/client/html-to-dom.ts 100.00% <100.00%> (ø)
src/client/utilities.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/server/html-to-dom.ts 100.00% <100.00%> (ø)
src/server/utilities.ts 100.00% <100.00%> (ø)
src/client/domparser.ts 68.51% <68.51%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@remarkablemark remarkablemark merged commit 9ddb1b4 into master Oct 16, 2023
@remarkablemark remarkablemark deleted the refactor/typescript branch October 16, 2023 05:08
@remarkablemark
Copy link
Copy Markdown
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant