fix: harden head and body regex in domparser#22
Merged
remarkablemark merged 5 commits intomasterfrom Nov 4, 2019
Merged
Conversation
Because the head and body regexes test against the closing tag,
this causes html with unclosed head or body to not be parsed
correctly.
For example, given the following:
```js
parse('<html><body>');
```
The expected output is:
```
[ { type: 'tag',
name: 'html',
attribs: {},
children:
[ { type: 'tag',
name: 'body',
attribs: {},
children: [],
next: null,
prev: null,
parent: [Circular] } ],
next: null,
prev: null,
parent: null } ]
```
But the actual output is:
```
[
{
"next": null,
"prev": null,
"parent": null,
"name": "html",
"attribs": {},
"type": "tag",
"children": []
}
]
```
The fix is to update the regex to use the opening tag instead of
the closing tag.
Add test case.
Fixes #18
Tidy code in `domparser.js`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18