Skip to content

lib/client/html-to-dom.mjs is not a valid ECMAScript Module #334

@gregatgoogle

Description

@gregatgoogle

0c4c2b6 has added https://github.com/remarkablemark/html-dom-parser/blob/master/lib/client/html-to-dom.mjs with

module.exports = HTMLDOMParser;
module.exports.default = HTMLDOMParser;

which are not valid ECMAScript exports statements (valid syntax). export and export default are, like in index.mjs.

The end result is this is that my project crashes on browser with ReferenceError: module is not defined.

Could you either revert that change or make it ECMAScript compliant?

Metadata

Metadata

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions