fix: allow blossom uploadBlob without login via temporary/custom signer#477
Merged
fix: allow blossom uploadBlob without login via temporary/custom signer#477
Conversation
- Add optional customSigner parameter to uploadBlob, uploadBlobFromFile, mirrorToServers, deleteBlob, and report methods - Create temporary signer automatically when no account is logged in - Update read operations (getBlob, downloadBlobToFile, checkBlob, getBlobStream, listBlobs) to support customSigner with useAuth - Remove unused _checkSigner() and _signer getter - Add tests for temporary signer functionality Fixes #476
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 75.91% 76.11% +0.20%
==========================================
Files 152 152
Lines 6223 6226 +3
==========================================
+ Hits 4724 4739 +15
+ Misses 1499 1487 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1-leo
approved these changes
Mar 2, 2026
Contributor
1-leo
left a comment
There was a problem hiding this comment.
what use is the tmp signer? I dont understand the usecase.
Feels quite implicit, maybe at least log a warning if tmp signer is used?
Collaborator
Author
|
The temp signer is here to be able to use the blossom usecase without providing a custom signer. As a dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #476