Skip to content

Feat signer pending requests#434

Merged
nogringo merged 11 commits intomasterfrom
feat/signer-pending-requests
Feb 17, 2026
Merged

Feat signer pending requests#434
nogringo merged 11 commits intomasterfrom
feat/signer-pending-requests

Conversation

@nogringo
Copy link
Collaborator

@nogringo nogringo commented Feb 9, 2026

Related to #433

@nogringo nogringo requested review from 1-leo and frnandu February 9, 2026 21:31
@nogringo nogringo self-assigned this Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.35%. Comparing base (702e5dd) to head (007da8d).
⚠️ Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
...layer/repositories/signers/nip46_event_signer.dart 86.48% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   75.18%   75.35%   +0.17%     
==========================================
  Files         144      147       +3     
  Lines        5763     5811      +48     
==========================================
+ Hits         4333     4379      +46     
- Misses       1430     1432       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo
Copy link
Contributor

1-leo commented Feb 11, 2026

  • add the user approval stream to accounts

@nogringo nogringo force-pushed the feat/signer-pending-requests branch from f2c3d9e to dfa2ef6 Compare February 11, 2026 13:47
Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 GJ!
I like the docs

  • test coverage >~80

@nogringo nogringo requested a review from 1-leo February 14, 2026 13:05
@nogringo nogringo merged commit d3ed86a into master Feb 17, 2026
3 checks passed
@nogringo nogringo deleted the feat/signer-pending-requests branch February 17, 2026 18:10
@frnandu frnandu added this to the 0.8 milestone Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants