Skip to content

feat(broadcast): add NIP-09 compliant deletion with e, k, and a tags#428

Merged
nogringo merged 2 commits intomasterfrom
feat/nip09-deletion-tags
Feb 17, 2026
Merged

feat(broadcast): add NIP-09 compliant deletion with e, k, and a tags#428
nogringo merged 2 commits intomasterfrom
feat/nip09-deletion-tags

Conversation

@nogringo
Copy link
Collaborator

@nogringo nogringo commented Feb 7, 2026

  • Add event/events params for deletion with k tag
  • Add eventAndAllVersions/eventsAndAllVersions params for a tag
  • Keep eventId/eventIds for backward compatibility
  • Generate a tag for any kind (extension beyond NIP-09)
  • Use Set for cache removal deduplication

@nogringo nogringo requested review from 1-leo and frnandu February 7, 2026 22:44
@nogringo nogringo self-assigned this Feb 7, 2026
@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.29%. Comparing base (da82df5) to head (304eec7).
⚠️ Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
...lib/domain_layer/usecases/broadcast/broadcast.dart 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   75.18%   75.29%   +0.10%     
==========================================
  Files         144      144              
  Lines        5763     5792      +29     
==========================================
+ Hits         4333     4361      +28     
- Misses       1430     1431       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only works in combination with #430 right?

@nogringo
Copy link
Collaborator Author

nogringo commented Feb 9, 2026

this only works in combination with #430 right?

No, but we will need #430 to make this PR clean.

- Add event/events params for deletion with k tag
- Add eventAndAllVersions/eventsAndAllVersions params for a tag
- Keep eventId/eventIds for backward compatibility
- Generate a tag for any kind (extension beyond NIP-09)
- Use Set for cache removal deduplication
@nogringo nogringo force-pushed the feat/nip09-deletion-tags branch from d4ad5f8 to 775d296 Compare February 10, 2026 12:10
@nogringo nogringo requested a review from 1-leo February 10, 2026 12:20
@1-leo
Copy link
Contributor

1-leo commented Feb 11, 2026

  • not perfect solution. Deligate known to delete to some kind of GC

Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed we need some kind of storage of deleted ids

@nogringo nogringo merged commit 818ac5e into master Feb 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants