feat: add of() method to fetch NIP-05 data without pubkey#382
Merged
feat: add of() method to fetch NIP-05 data without pubkey#382
Conversation
1-leo
reviewed
Jan 24, 2026
packages/ndk/lib/domain_layer/usecases/nip05/verify_nip_05.dart
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
==========================================
+ Coverage 72.30% 72.47% +0.17%
==========================================
Files 144 144
Lines 5585 5620 +35
==========================================
+ Hits 4038 4073 +35
Misses 1547 1547 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frnandu
approved these changes
Jan 29, 2026
1-leo
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ndk.nip05.of("pubkey")never read from cache. Do we need update cache managers with a method to get the pubkey from the nip05 idetifier ?Close #208