Skip to content

fix: isolate pool size to use numberOfProcessors#379

Merged
1-leo merged 5 commits intomasterfrom
fix-isolate-pool-size
Jan 24, 2026
Merged

fix: isolate pool size to use numberOfProcessors#379
1-leo merged 5 commits intomasterfrom
fix-isolate-pool-size

Conversation

@frnandu
Copy link
Collaborator

@frnandu frnandu commented Jan 22, 2026

use numberOfProcessors / 4 for isolate pool sizes & add some logging during initialization

@1-leo 1-leo self-requested a review January 22, 2026 17:46
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.41%. Comparing base (5806891) to head (f940e34).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...es/ndk/lib/shared/isolates/isolate_manager_io.dart 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   72.35%   72.41%   +0.05%     
==========================================
  Files         144      144              
  Lines        5585     5593       +8     
==========================================
+ Hits         4041     4050       +9     
+ Misses       1544     1543       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo
Copy link
Contributor

1-leo commented Jan 22, 2026

!!! profiler needs to be removed from prod code !!!
(after testing)

@frnandu frnandu requested a review from 1-leo January 22, 2026 19:14
Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • removed the profiler in prod code (its still in /test)

@1-leo 1-leo added the bug Something isn't working label Jan 23, 2026
@1-leo 1-leo added this to ndk-dev Jan 23, 2026
@1-leo 1-leo moved this to In Progress in ndk-dev Jan 23, 2026
@1-leo 1-leo merged commit 1dbb853 into master Jan 24, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ndk-dev Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants