feat: nip01event immutable light#348
Merged
frnandu merged 1 commit intofix-websocket-performance-issues-2-refactor-nip-01from Dec 22, 2025
Merged
feat: nip01event immutable light#348frnandu merged 1 commit intofix-websocket-performance-issues-2-refactor-nip-01from
frnandu merged 1 commit intofix-websocket-performance-issues-2-refactor-nip-01from
Conversation
1-leo
requested changes
Dec 22, 2025
Contributor
1-leo
left a comment
There was a problem hiding this comment.
This review is a bit messy. I started by commenting on every occurrence but noticed that it does not make sense. Find and replace will do this in ms
Its basically
instead of
final event = Nip01Event(do
final event = Nip01Utils.createEventCalculateId(in our own code so we "future proof " it already.
Has the benefit that we can easily switch to async calc id where possible.
| // broadcast a new event using the logged in account with it's signer to sign | ||
| NdkBroadcastResponse response = ndk.broadcast.broadcast( | ||
| nostrEvent: Nip01EventService.createEventCalculateId( | ||
| nostrEvent: Nip01Event( |
Contributor
There was a problem hiding this comment.
In the example, we should advise using the new method. Using Nip01Utils
| ); | ||
|
|
||
| final requestEvent = Nip01EventService.createEventCalculateId( | ||
| final requestEvent = Nip01Event( |
Contributor
There was a problem hiding this comment.
In our own code we should use the new method. Using Nip01Utils
| NostrMessageRaw nostrMsg; | ||
| try { | ||
| nostrMsg = await IsolateManager.instance | ||
| .runInEncodingIsolate<String, NostrMessageRaw>( |
Contributor
There was a problem hiding this comment.
as discussed, we can leave it for now and I try to do this in the isolate manager (web support)
c65eaaa
into
fix-websocket-performance-issues-2-refactor-nip-01
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.