fix: Handle null error value in NWC response deserialization#334
Merged
frnandu merged 1 commit intorelaystr:masterfrom Dec 9, 2025
Merged
fix: Handle null error value in NWC response deserialization#334frnandu merged 1 commit intorelaystr:masterfrom
frnandu merged 1 commit intorelaystr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deserializeError method in
NwcResponsewas attempting to cast theerrorfield to aMap<String, dynamic>without checking if it wasnull. This caused connection failures when NWC wallet providers (like Rizful) send responses witherror: nullin their JSON payloads.Example of problematic response format:
{ "result_type": "get_balance", "result": {"balance": 100000}, "error": null }When this response was processed, the code would try to cast
nulltoMap<String, dynamic>, causing a runtime error and preventing successful wallet connections.This bug was discovered during testing of my app Nostrpay with the Rizful wallet provider. Users reported connection failures when attempting to connect their Rizful wallet through NWC. The issue was reported in this Stacker.news discussion.
I just added a null check before attempting to cast the error field to a Map.