Nip19 nprofile, naddr and nevent support#292
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 69.06% 71.13% +2.06%
==========================================
Files 129 136 +7
Lines 4551 4763 +212
==========================================
+ Hits 3143 3388 +245
+ Misses 1408 1375 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1-leo
approved these changes
Nov 17, 2025
Contributor
1-leo
left a comment
There was a problem hiding this comment.
looks good but there are still some var instead of final
I did not mark all of them in the previous review
Collaborator
Author
Should I replace them all ? |
frnandu
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.