Skip to content

Broadcast deletion upgrade (delete multiple ids)#279

Merged
nogringo merged 2 commits intomasterfrom
broadcast-deletion-upgrade
Nov 10, 2025
Merged

Broadcast deletion upgrade (delete multiple ids)#279
nogringo merged 2 commits intomasterfrom
broadcast-deletion-upgrade

Conversation

@nogringo
Copy link
Collaborator

@nogringo nogringo commented Nov 9, 2025

fixes #215

@nogringo nogringo requested review from 1-leo and frnandu November 9, 2025 15:51
@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.90%. Comparing base (36a43c3) to head (0f4ffff).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   68.91%   68.90%   -0.01%     
==========================================
  Files         129      129              
  Lines        4539     4544       +5     
==========================================
+ Hits         3128     3131       +3     
- Misses       1411     1413       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo 1-leo changed the title Broadcast deletion upgrade Broadcast deletion upgrade (delete multiple ids) Nov 10, 2025
@1-leo
Copy link
Contributor

1-leo commented Nov 10, 2025

would be a breaking change, do a commit with feat!: or refactor!:

@nogringo
Copy link
Collaborator Author

would be a breaking change, do a commit with feat!: or refactor!:

Why would it be a breaking change ?

@1-leo
Copy link
Contributor

1-leo commented Nov 10, 2025

Ah, never mind, just noticed you made it backwards compatible with

String? eventId,
List<String>? eventIds,

💪

@nogringo nogringo merged commit 68d019d into master Nov 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

delete multiple events

3 participants