Skip to content

Fix subscriptions with trailing /#266

Merged
nogringo merged 4 commits intomasterfrom
trailing-slash
Oct 30, 2025
Merged

Fix subscriptions with trailing /#266
nogringo merged 4 commits intomasterfrom
trailing-slash

Conversation

@nogringo
Copy link
Collaborator

No description provided.

@nogringo nogringo requested review from 1-leo and frnandu October 29, 2025 18:31
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.92%. Comparing base (fb0ed28) to head (f2ea471).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   68.78%   68.92%   +0.14%     
==========================================
  Files         129      129              
  Lines        4501     4502       +1     
==========================================
+ Hits         3096     3103       +7     
+ Misses       1405     1399       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this only an issue in relay_sets_engine?
Testing this against JIT engine would be nice

@nogringo nogringo requested a review from 1-leo October 29, 2025 21:01
@nogringo
Copy link
Collaborator Author

Everything work, just the Broadcast with trailling / test is slower than the others and I do not really know why.

@frnandu
Copy link
Collaborator

frnandu commented Oct 29, 2025

let's move the trailing test into test/relays/ directory

@nogringo nogringo merged commit 420c1d5 into master Oct 30, 2025
3 checks passed
@nogringo nogringo deleted the trailing-slash branch October 30, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants