Skip to content

chore fix analyzer issues ndk#259

Merged
1-leo merged 2 commits intomasterfrom
chore-fix-analyzer-issues
Oct 29, 2025
Merged

chore fix analyzer issues ndk#259
1-leo merged 2 commits intomasterfrom
chore-fix-analyzer-issues

Conversation

@1-leo
Copy link
Contributor

@1-leo 1-leo commented Oct 23, 2025

fixing issues from dart analyze

@1-leo 1-leo self-assigned this Oct 23, 2025
@1-leo 1-leo added the bug Something isn't working label Oct 23, 2025
@1-leo 1-leo added this to ndk-dev Oct 23, 2025
@1-leo 1-leo moved this to In Progress in ndk-dev Oct 23, 2025
@1-leo 1-leo requested review from frnandu and nogringo October 23, 2025 09:55
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.54%. Comparing base (d7cbbb7) to head (b2e4a42).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ib/domain_layer/usecases/nwc/nwc_notification.dart 25.00% 3 Missing ⚠️
...ases/nwc/responses/list_transactions_response.dart 66.66% 1 Missing ⚠️
.../usecases/nwc/responses/make_invoice_response.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   68.54%   68.54%           
=======================================
  Files         126      126           
  Lines        4467     4467           
=======================================
  Hits         3062     3062           
  Misses       1405     1405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo 1-leo merged commit 6c1f4a1 into master Oct 29, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ndk-dev Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants