Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 71.52% 71.52%
=======================================
Files 125 125
Lines 4400 4400
=======================================
Hits 3147 3147
Misses 1253 1253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1-leo
left a comment
There was a problem hiding this comment.
Good starting point.
I think the widgets could be more configurable, providing default options and taking params to change the style etc.
- docs for the params
There was a problem hiding this comment.
how can the user extend language files?
A example on how this could work might be nice. (or sample app)
There was a problem hiding this comment.
is there a way that does not require our input?
| child: PrettyQrView.data( | ||
| data: nostrConnectURL, | ||
| decoration: const PrettyQrDecoration( | ||
| shape: PrettyQrShape.custom(PrettyQrDotsSymbol()), |
There was a problem hiding this comment.
We can add cutomisation in the future
There was a problem hiding this comment.
for dependencies like secure storage, crypto etc it might make sense to use version ranges to increase compatibility with the developers packages
There was a problem hiding this comment.
pushed it, please check if it works for you
|
can we modify here the demo-app to use this stuff, otherwise it's hard to test it and evaluate it |
NPicture use the metadata pubkey if present
No description provided.