Skip to content

fix flanky test, any order#240

Merged
1-leo merged 1 commit intomasterfrom
fix-test-cache-read-any-order
Oct 1, 2025
Merged

fix flanky test, any order#240
1-leo merged 1 commit intomasterfrom
fix-test-cache-read-any-order

Conversation

@1-leo
Copy link
Contributor

@1-leo 1-leo commented Oct 1, 2025

fixes flanky test, where cache responds in any order

❌ test/usecases/cache_read_test.dart: CacheRead cache read - has events for all authors (failed)
  Expected: [
              Nip01Event:Nip01Event{pubKey: pubKey1, createdAt: 1759316888, kind: 1, tags: [], content: content1_a, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey1, createdAt: 1759316889, kind: 1, tags: [], content: content1_b, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey1, createdAt: 1759316889, kind: 1, tags: [], content: content1_c, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey2, createdAt: 1759316889, kind: 1, tags: [], content: content2_a, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey2, createdAt: 1759316889, kind: 1, tags: [], content: content2_b, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey2, createdAt: 1759316889, kind: 1, tags: [], content: content2_c, sources: []}
            ]
    Actual: [
              Nip01Event:Nip01Event{pubKey: pubKey1, createdAt: 1759316889, kind: 1, tags: [], content: content1_b, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey1, createdAt: 1759316889, kind: 1, tags: [], content: content1_c, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey2, createdAt: 1759316889, kind: 1, tags: [], content: content2_a, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey2, createdAt: 1759316889, kind: 1, tags: [], content: content2_b, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey2, createdAt: 1759316889, kind: 1, tags: [], content: content2_c, sources: []},
              Nip01Event:Nip01Event{pubKey: pubKey1, createdAt: 1759316888, kind: 1, tags: [], content: content1_a, sources: []}
            ]
     Which: at location [0] is Nip01Event:<Nip01Event{pubKey: pubKey1, createdAt: 1759316889, kind: 1, tags: [], content: content1_b, sources: []}> instead of Nip01Event:<Nip01Event{pubKey: pubKey1, createdAt: 1759316888, kind: 1, tags: [], content: content1_a, sources: []}>
     ```

@1-leo 1-leo self-assigned this Oct 1, 2025
@1-leo 1-leo added the bug Something isn't working label Oct 1, 2025
@1-leo 1-leo added this to ndk-dev Oct 1, 2025
@1-leo 1-leo moved this to In Progress in ndk-dev Oct 1, 2025
@1-leo
Copy link
Contributor Author

1-leo commented Oct 1, 2025

ci still fails because of #234

@1-leo 1-leo merged commit 2c586db into master Oct 1, 2025
0 of 2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ndk-dev Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant