Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 71.52% 71.75% +0.23%
==========================================
Files 125 125
Lines 4400 4415 +15
==========================================
+ Hits 3147 3168 +21
+ Misses 1253 1247 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1-leo
approved these changes
Sep 13, 2025
Contributor
1-leo
left a comment
There was a problem hiding this comment.
👍nice!
Maybe instead of StreamController a BehaviorSubject so the latest value is always available:
https://pub.dev/packages/rxdart#subjects
1-leo
requested changes
Sep 13, 2025
Contributor
1-leo
left a comment
There was a problem hiding this comment.
wait the tests do not check if the actual stream changes, you can do this with
await expectLater(stream, emitsInOrder(<expected>));
1-leo
approved these changes
Sep 14, 2025
Contributor
=> skip (for now) => #234 |
frnandu
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a stream in the Account class to listen to auth state changes.