Nip46 mock remote signer and nip46 tests updated#216
Merged
nogringo merged 5 commits intonip46-event-signerfrom Aug 14, 2025
Merged
Nip46 mock remote signer and nip46 tests updated#216nogringo merged 5 commits intonip46-event-signerfrom
nogringo merged 5 commits intonip46-event-signerfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## nip46-event-signer #216 +/- ##
======================================================
+ Coverage 67.83% 71.50% +3.66%
======================================================
Files 124 124
Lines 4393 4393
======================================================
+ Hits 2980 3141 +161
+ Misses 1413 1252 -161 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frnandu
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
There is no test for the nostr connect