Merged
Conversation
added 2 commits
August 6, 2025 21:18
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## nip46-event-signer #213 +/- ##
=====================================================
Coverage ? 67.83%
=====================================================
Files ? 124
Lines ? 4393
Branches ? 0
=====================================================
Hits ? 2980
Misses ? 1413
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
nogringo
reviewed
Aug 7, 2025
nogringo
reviewed
Aug 7, 2025
nogringo
reviewed
Aug 7, 2025
nogringo
reviewed
Aug 7, 2025
nogringo
reviewed
Aug 7, 2025
1-leo
approved these changes
Aug 8, 2025
| await ndk.accounts.loginWithBunkerUrl( | ||
| bunkerUrl: | ||
| "bunker://a1fe3664f7a2b24db97e5b63869e8011c947f9abd8c03f98befafd27c38467d2?relay=wss://relay.nsec.app&secret=devsecret123", | ||
| bunkers: ndk.bunkers); |
Contributor
There was a problem hiding this comment.
can we pass in the bunkers usecase by default?
Collaborator
Author
There was a problem hiding this comment.
You mean in the accounts? It causes circular dependency. Do you have an idea how to solve that?
Contributor
There was a problem hiding this comment.
Hmm i suspected this is the reason. I need a closer look, mabye with a factory
nogringo
approved these changes
Aug 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.