Skip to content

fix reconnection warnings#183

Merged
1-leo merged 4 commits intomasterfrom
182-fix-log-msg
Jul 2, 2025
Merged

fix reconnection warnings#183
1-leo merged 4 commits intomasterfrom
182-fix-log-msg

Conversation

@1-leo
Copy link
Contributor

@1-leo 1-leo commented Jun 25, 2025

fixed common warning msg when using ndk

@1-leo 1-leo linked an issue Jun 25, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.23%. Comparing base (5e67f35) to head (0d70a81).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...k/lib/domain_layer/usecases/requests/requests.dart 66.66% 2 Missing ⚠️
...s/ndk/lib/domain_layer/usecases/relay_manager.dart 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   71.22%   71.23%   +0.01%     
==========================================
  Files         120      120              
  Lines        4163     4168       +5     
==========================================
+ Hits         2965     2969       +4     
- Misses       1198     1199       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo 1-leo marked this pull request as ready for review June 25, 2025 13:23
@1-leo
Copy link
Contributor Author

1-leo commented Jun 25, 2025

the warning

 RECEIVED EVENT from wss://<relay> for id q-homeFeed-yumwcFYeDk, not in globalState inFlightRequests

happens when a relay sends data after eose and the close msg is not yet recived/processed on the relay
Because our cleanup now works we no longer have the state in mem

@1-leo 1-leo requested a review from frnandu June 25, 2025 13:25
@1-leo 1-leo self-assigned this Jun 25, 2025
@1-leo 1-leo added the bug Something isn't working label Jun 25, 2025
@1-leo 1-leo merged commit 5766650 into master Jul 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix log msg

2 participants