Skip to content

refactor: list usecase, add generic methods#176

Merged
1-leo merged 27 commits intomasterfrom
175-refactor-list-usecase
Nov 20, 2025
Merged

refactor: list usecase, add generic methods#176
1-leo merged 27 commits intomasterfrom
175-refactor-list-usecase

Conversation

@1-leo
Copy link
Contributor

@1-leo 1-leo commented Jun 4, 2025 •
edited
Loading

#175

User Story

As a dev i want to recive data as fast as possible for every list type
Acceptance Criteria

stream interface
generic for all list types
get list by name (if possible)

Alternatives Considered
Additional Context

right now it takes some time to get a list if there is a failing relay in the list.

changes:

new Methods:

  • getSingleNip51List()
  • addElementToList()
  • removeElementFromList()
  • getSetByName()
  • getPublicSets()
  • addElementToSet()
  • removeElementFromSet()
  • setCompleteSet()
  • deleteSet()

deprecated Methods:

  • getPublicNip51RelaySets()
  • broadcastAddNip51SetRelay()
  • broadcastRemoveNip51SetRelay()
  • broadcastAddNip51ListRelay()
  • broadcastRemoveNip51Relay()
  • broadcastAddNip51ListElement()
  • broadcastRemoveNip51ListElement()
  • getSinglePublicNip51RelaySet()

@1-leo 1-leo self-assigned this Jun 4, 2025
@1-leo 1-leo linked an issue Jun 4, 2025 that may be closed by this pull request
refactor list usecase #175
Closed
@codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 87.30964% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.83%. Comparing base (55fd631) to head (28657a4).
⚠️ Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
...ges/ndk/lib/domain_layer/usecases/lists/lists.dart 87.57% 21 Missing ⚠️
...ges/ndk/lib/domain_layer/entities/nip_51_list.dart 85.71% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   71.06%   70.83%   -0.23%     
==========================================
  Files         136      136              
  Lines        4766     5048     +282     
==========================================
+ Hits         3387     3576     +189     
- Misses       1379     1472      +93

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo 1-leo marked this pull request as ready for review July 2, 2025 13:30
@1-leo 1-leo requested a review from frnandu July 2, 2025 13:30
@frnandu frnandu added this to the 0.5 milestone Jul 2, 2025
frnandu
frnandu reviewed Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@frnandu frnandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests would be nice

@frnandu frnandu removed this from the 0.5 milestone Jul 29, 2025
@1-leo 1-leo requested review from frnandu and nogringo November 11, 2025 17:51
@1-leo 1-leo added this to ndk-dev Nov 11, 2025
@1-leo 1-leo moved this to In Progress in ndk-dev Nov 11, 2025
@1-leo 1-leo added the enhancement New feature or request label Nov 11, 2025
@1-leo 1-leo added this to the 0.6 milestone Nov 11, 2025
@frnandu
Copy link
Collaborator

frnandu commented Nov 12, 2025

maybe worth to rename the PR to a better title and add small description of changes for the release changelog

@1-leo 1-leo changed the title 175 refactor list usecase refactor: list usecase, add generic methods Nov 12, 2025
@1-leo
Copy link
Contributor Author

1-leo commented Nov 17, 2025 •
edited
Loading

  • check signer param (we dont need it with the accounts usecase)

frnandu
frnandu approved these changes Nov 19, 2025
View reviewed changes
@1-leo 1-leo merged commit b170666 into master Nov 20, 2025
2 of 3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ndk-dev Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frnandu frnandu frnandu approved these changes

@nogringo nogringo nogringo approved these changes

Assignees

@1-leo 1-leo

Labels

enhancement New feature or request

Projects

ndk-dev
Status: Done

Milestone

0.6

Development

Successfully merging this pull request may close these issues.

refactor list usecase

3 participants

@1-leo @frnandu @nogringo