feat: make broadcast async for relays in relays_set engine#168
Merged
feat: make broadcast async for relays in relays_set engine#168
Conversation
1-leo
approved these changes
May 29, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #168 +/- ##
==========================================
- Coverage 70.93% 70.79% -0.15%
==========================================
Files 118 118
Lines 4042 4050 +8
==========================================
Hits 2867 2867
- Misses 1175 1183 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1-leo
approved these changes
May 30, 2025
| } | ||
|
|
||
| /// use this to signal a failed broadcast | ||
| void failBroadcast(String nostrEventId, String relay, String msg) { |
Contributor
There was a problem hiding this comment.
maybe name this deregister?
So its more clear that you need to register and deregister on fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #166