Skip to content

Fix connection to a bad relay blocking event delivery#164

Merged
frnandu merged 2 commits intomasterfrom
fix/reconnect-relay-parallel
May 27, 2025
Merged

Fix connection to a bad relay blocking event delivery#164
frnandu merged 2 commits intomasterfrom
fix/reconnect-relay-parallel

Conversation

@frnandu
Copy link
Collaborator

@frnandu frnandu commented May 26, 2025

Make reconnect to relays async to not block other relays responding immediately in RELAYS_SET engine

fixes #154

@v0l try this on zapstream, should fix the 5s delay that wss://relay.nostr.bg bad relay was causing.

@frnandu frnandu added this to the 0.4 milestone May 26, 2025
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.93%. Comparing base (bf4b04e) to head (6242899).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...k/lib/domain_layer/usecases/relay_sets_engine.dart 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   70.79%   70.93%   +0.14%     
==========================================
  Files         118      118              
  Lines        4050     4042       -8     
==========================================
  Hits         2867     2867              
+ Misses       1183     1175       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@v0l
Copy link
Contributor

v0l commented May 27, 2025

YES its much faster!

@frnandu frnandu merged commit d1bfa75 into master May 27, 2025
2 of 3 checks passed
@v0l
Copy link
Contributor

v0l commented May 27, 2025

There also seems to be a similar issue with relay.nostr.bg when publishing

@frnandu
Copy link
Collaborator Author

frnandu commented May 27, 2025

There also seems to be a similar issue with relay.nostr.bg when publishing

Thanks, will fix it in a separate issue/PR #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RELAY_SETS engine takes 5s to load some events

2 participants