Skip to content

add support for multiple filters on RELAYS_SET engine#153

Merged
frnandu merged 3 commits intomasterfrom
multiple-filters-relays-set
May 16, 2025
Merged

add support for multiple filters on RELAYS_SET engine#153
frnandu merged 3 commits intomasterfrom
multiple-filters-relays-set

Conversation

@frnandu
Copy link
Collaborator

@frnandu frnandu commented May 13, 2025

fixes #152

@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.02%. Comparing base (8ed70f0) to head (6f8c6aa).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
...k/lib/domain_layer/usecases/relay_sets_engine.dart 61.11% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   71.98%   72.02%   +0.04%     
==========================================
  Files         113      113              
  Lines        3851     3853       +2     
==========================================
+ Hits         2772     2775       +3     
+ Misses       1079     1078       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frnandu frnandu requested a review from 1-leo May 13, 2025 14:31
@1-leo 1-leo moved this to In Progress in ndk-dev May 15, 2025
@1-leo 1-leo added this to ndk-dev May 15, 2025
@1-leo 1-leo added this to the 0.4 milestone May 15, 2025
Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just some var vs final and maybe dart format so pub.dev doesnt complain

@frnandu frnandu merged commit 0d4331e into master May 16, 2025
2 of 3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ndk-dev May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

fix support for multiple filters in NdkEngine.RELAY_SETS

2 participants