fix(out): escape backslashes in output shell scripts#35
Merged
relastle merged 4 commits intorelastle:masterfrom Dec 24, 2020
Merged
fix(out): escape backslashes in output shell scripts#35relastle merged 4 commits intorelastle:masterfrom
relastle merged 4 commits intorelastle:masterfrom
Conversation
75ceec3 to
7c23c76
Compare
7c23c76 to
501044d
Compare
relastle
approved these changes
Dec 24, 2020
Owner
relastle
left a comment
There was a problem hiding this comment.
And echo also causes strange behavior.
The escape processing of the echo argument changes depending on the environment.
In the case of zsh, echo performs escaping, but command echo does not.
This is interesting knowledge I've never known.
Thank you for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abst: This is a suggestion that the
\contained in the output ofpmy mainshould be escaped.Currently, backslashes in the output of
pmy mainare not escaped.For example,
~/.pmy/rules/pmy_rules.ymlis:Then,
pmy mainoutputs the script below:This means
$__pmy_out_command==print 'A\nB' ;, andeval $__pmy_out_commandoutputsA<LF>B.And
echoalso causes strange behavior.The escape processing of the
echoargument changes depending on the environment.In the case of zsh,
echoperforms escaping, butcommand echodoes not.