Fix key name of retrieved_contexts in the dataset evaluation sample#68
Merged
yisz merged 1 commit intorelari-ai:mainfrom Jun 11, 2024
Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 3f11459 in 32 seconds
More details
- Looked at
19lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. examples/evaluation_on_dataset.py:17
- Draft comment:
The change fromretrieved_contexttoretrieved_contextsseems appropriate given the PR description. However, please ensure that the dataset actually contains a key namedretrieved_contextsand that it is used consistently throughout the codebase. This change should also be reflected in any documentation or examples that use the old key name. - Reason this comment was not posted:
Confidence changes required:33%
The PR author has changed the key from 'retrieved_context' to 'retrieved_contexts' in the evaluation script. This change is consistent with the description provided by the PR author, which mentions that the correct key in the dataset is 'retrieved_contexts'. I need to verify if this change is correctly applied in all relevant places in the code and if it aligns with the dataset structure.
Workflow ID: wflow_ORuKT5p6cZW9uuuT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
|
@jmartisk that's correct! Thank you for catching that and contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope I'm not misunderstanding something, but the relevant key in https://ceevaldata.blob.core.windows.net/examples/retrieval.jsonl is
retrieved_contextsSummary:
This PR fixes the key name for retrieved contexts in the dataset evaluation sample to align with the dataset's JSON structure.
Key points:
retrieved_contexttoretrieved_contextsinexamples/evaluation_on_dataset.pyPrecisionRecallF1andRankedRetrievalMetricsclassesGenerated with ❤️ by ellipsis.dev