Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a9e8583 in 33 seconds
More details
- Looked at
112lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. continuous_eval/llm_factory.py:42
- Draft comment:
It's important to include a description in the PR to explain the reason for these changes and how they improve the functionality or fix an issue. This helps reviewers understand the context and the intent behind the changes. - Reason this comment was not posted:
Confidence changes required:33%
The PR description is empty, which is not ideal because it doesn't provide context or reasoning behind the changes. However, the code changes suggest that themax_tokensparameter is being added to therunmethod of theLLMInterfaceand its implementations. This parameter controls the maximum number of tokens the model should generate in response to a prompt. The changes are consistent across the file, and the default value formax_tokensis set to 1024, which is a reasonable default for many language models.
Workflow ID: wflow_NABLkaixgi063xd4
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
pantonante
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a
max_tokensparameter to the LLM interface methods, allowing control over the number of tokens generated, and adds Cohere API key support in the environment configuration.Key points:
max_tokensparameter toLLMInterface.runandLLMFactory.runwith a default of 1024._llm_responseinLLMFactoryto passmax_tokensto LLM client calls.COHERE_API_KEYto.env.example.Generated with ❤️ by ellipsis.dev