Fix required keyword for code string to ground_truth_answers#56
Merged
pantonante merged 1 commit intorelari-ai:mainfrom Apr 8, 2024
Merged
Fix required keyword for code string to ground_truth_answers#56pantonante merged 1 commit intorelari-ai:mainfrom
pantonante merged 1 commit intorelari-ai:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to a21ae5a
- Looked at
36lines of code in2files - Took 1 minute and 3 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
2additional comments because they didn't meet confidence threshold of50%.
1. /docs/src/content/docs/metrics/Code/Deterministic/python_ast_similarity.md:21:
- Assessed confidence :
50% - Comment:
The change from 'ground_truths' to 'ground_truth_answers' seems correct, but it would be good to confirm this by checking the actual implementation of the PythonASTSimilarity class. - Reasoning:
The changes in the PR seem to be correct. The author has changed the keyword from 'ground_truths' to 'ground_truth_answers' in the documentation. I need to check the actual implementation of the PythonASTSimilarity and CodeStringMatch classes to confirm if 'ground_truth_answers' is the correct keyword.
2. /docs/src/content/docs/metrics/Code/Deterministic/string_match.md:18:
- Assessed confidence :
50% - Comment:
The change from 'ground_truths' to 'ground_truth_answers' seems correct, but it would be good to confirm this by checking the actual implementation of the CodeStringMatch class. - Reasoning:
The changes in the PR seem to be correct. The author has changed the keyword from 'ground_truths' to 'ground_truth_answers' in the documentation. I need to check the actual implementation of the CodeStringMatch class to confirm if 'ground_truth_answers' is the correct keyword.
Workflow ID: wflow_dVzrT82zkl8vOU21
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Contributor
|
Thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thanks for this awesome library.
small docs fixes for code string match metrics: setting keyword to ground_truth_answers
Summary:
This PR updates the keyword from
ground_truthstoground_truth_answersin the documentation of two metrics.Key points:
ground_truthstoground_truth_answersin documentation./docs/src/content/docs/metrics/Code/Deterministic/python_ast_similarity.mdand/docs/src/content/docs/metrics/Code/Deterministic/string_match.md.Generated with ❤️ by ellipsis.dev