Add rehype-callouts to list of plugins#175
Merged
wooorm merged 1 commit intorehypejs:mainfrom Aug 22, 2024
lin-stephanie:patch-1
Merged
Add rehype-callouts to list of plugins#175wooorm merged 1 commit intorehypejs:mainfrom lin-stephanie:patch-1
rehype-callouts to list of plugins#175wooorm merged 1 commit intorehypejs:mainfrom
lin-stephanie:patch-1
Conversation
Signed-off-by: 椰云拿铁 <102728558+lin-stephanie@users.noreply.github.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 154 154
=========================================
Hits 154 154 ☔ View full report in Codecov by Sentry. |
ChristianMurphy
approved these changes
Aug 21, 2024
Member
There was a problem hiding this comment.
Thanks @lin-stephanie!
This plugin looks really good.
It's great that testing, types, and lint checks area already in place.
Some subtle, non-blocking thoughts:
@types/hastis included in the distributed/production types, it could be good to move it to adependency(rather thendevDependency) to ensure stricter package managers like yarn/pnpm are happy using it https://github.com/lin-stephanie/rehype-callouts/blob/a48cda574d01d6b931d954f93fec36e0517675d8/package.json#L53- It looks like publishing is done through a GitHub action, it could be good to include provenance information to allow adopters to trace the release back to a specific build https://github.blog/security/supply-chain-security/introducing-npm-package-provenance/, though it might take some tinkering to get that to work with
pnpmpnpm/pnpm#6607
wooorm
approved these changes
Aug 22, 2024
Member
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Thanks for the merge @wooorm and suggestions @ChristianMurphy! I’ll consider them for the next update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Added a new plugin
rehype-calloutsto list of plugins