Add a piggy back migration for jpeg turbo#1602
Conversation
f313500 to
e59916d
Compare
|
Hmmm, not sure what is wrong. |
|
@jschueller @ocefpaf I think this is the last piece of the puzzle. If you wanted to help that would be appreciated. I know you were interested in this in the past. |
|
I'm just passing by, but isn't "JpegTuroboMigrator" a typo? |
Yes! Definitely a bug! Sadly, not the one holding me up :( |
If I'm being honest. I kind of like TuroboMigrator ;-p @hmaarrfk thanks for doing this! We should add this to the next meeting agenda and, hopefully, address one of the oldest standing issue in conda-forge. |
|
If you can fix the bug. You can call it whatever you want! In the same light, if you can fix the bug, i don't think there will be many objections too ING forward with this. |
I think we'll need help from folks that are more familiar with the code here. I hope we can get their attention at the meeting. |
|
I can try and look at this tonight. Sometimes you need to run the tests locally with a lot of output to see what's happening. |
|
Thank you. Yeah. I mostly tried to copy our qt mini migrator. I used that to troubleshoot alot. |
|
Double check the recipe yaml for after the migration. I don't see jpeg turbo anywhere in it. I also see a potential issue with openjpeg be changed too and I am not sure if you want that. |
Codecov ReportBase: 64.70% // Head: 64.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1602 +/- ##
==========================================
+ Coverage 64.70% 64.90% +0.19%
==========================================
Files 84 86 +2
Lines 8192 8230 +38
==========================================
+ Hits 5301 5342 +41
+ Misses 2891 2888 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
wow!!! many thanks |
|
Happy to help! The issue was that the test bumped pillow to a version that didn't appear to exist. The tests run the version update live and so they failed due to the missing version. |
|
um. did you really mean to merge this first? THis is really part of a larger plan. We should merge the other things I listed in conda-forge/conda-forge.github.io#673 (comment) first right? |
|
Woops! I thought it was ready. My apologies. I will back it out. |
|
the patch is ready. i think the decision is not yet finalized |
Piggy backs off conda-forge/conda-forge-pinning-feedstock#4091
xref: conda-forge/conda-forge.github.io#673