Skip to content

Add a piggy back migration for jpeg turbo#1602

Merged
beckermr merged 7 commits intoregro:masterfrom
hmaarrfk:jpeg_to_turbo
Feb 14, 2023
Merged

Add a piggy back migration for jpeg turbo#1602
beckermr merged 7 commits intoregro:masterfrom
hmaarrfk:jpeg_to_turbo

Conversation

@hmaarrfk
Copy link
Copy Markdown
Contributor

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

Hmmm, not sure what is wrong.

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

@jschueller @ocefpaf I think this is the last piece of the puzzle. If you wanted to help that would be appreciated. I know you were interested in this in the past.

@eddy-geek
Copy link
Copy Markdown

I'm just passing by, but isn't "JpegTuroboMigrator" a typo?

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

I'm just passing by, but isn't "JpegTuroboMigrator" a typo?

Yes! Definitely a bug!

Sadly, not the one holding me up :(

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Feb 13, 2023

I'm just passing by, but isn't "JpegTuroboMigrator" a typo?

If I'm being honest. I kind of like TuroboMigrator ;-p

@hmaarrfk thanks for doing this! We should add this to the next meeting agenda and, hopefully, address one of the oldest standing issue in conda-forge.

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

If you can fix the bug. You can call it whatever you want!

In the same light, if you can fix the bug, i don't think there will be many objections too ING forward with this.

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Feb 13, 2023

In the same light, if you can fix the bug, i don't think there will be many objections too ING forward with this.

I think we'll need help from folks that are more familiar with the code here. I hope we can get their attention at the meeting.

@beckermr
Copy link
Copy Markdown
Contributor

I can try and look at this tonight. Sometimes you need to run the tests locally with a lot of output to see what's happening.

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

Thank you. Yeah. I mostly tried to copy our qt mini migrator. I used that to troubleshoot alot.

@beckermr
Copy link
Copy Markdown
Contributor

Double check the recipe yaml for after the migration. I don't see jpeg turbo anywhere in it. I also see a potential issue with openjpeg be changed too and I am not sure if you want that.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2023

Codecov Report

Base: 64.70% // Head: 64.90% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (7adb0ff) compared to base (1ee2ae1).
Patch coverage: 94.73% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
+ Coverage   64.70%   64.90%   +0.19%     
==========================================
  Files          84       86       +2     
  Lines        8192     8230      +38     
==========================================
+ Hits         5301     5342      +41     
+ Misses       2891     2888       -3     
Impacted Files Coverage Δ
conda_forge_tick/audit.py 32.65% <ø> (ø)
conda_forge_tick/auto_tick.py 0.00% <0.00%> (ø)
conda_forge_tick/migrators/__init__.py 100.00% <100.00%> (ø)
conda_forge_tick/migrators/jpegturbo.py 100.00% <100.00%> (ø)
tests/test_jpeg_libjpeg_turbo.py 100.00% <100.00%> (ø)
conda_forge_tick/mamba_solver.py 61.57% <0.00%> (-0.24%) ⬇️
conda_forge_tick/migrators/version.py 77.28% <0.00%> (+0.44%) ⬆️
conda_forge_tick/hashing.py 75.75% <0.00%> (+6.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

wow!!! many thanks

@beckermr
Copy link
Copy Markdown
Contributor

Happy to help! The issue was that the test bumped pillow to a version that didn't appear to exist. The tests run the version update live and so they failed due to the missing version.

@beckermr beckermr merged commit a5dbcf9 into regro:master Feb 14, 2023
@hmaarrfk
Copy link
Copy Markdown
Contributor Author

um. did you really mean to merge this first? THis is really part of a larger plan. We should merge the other things I listed in conda-forge/conda-forge.github.io#673 (comment) first right?

@beckermr
Copy link
Copy Markdown
Contributor

Woops! I thought it was ready. My apologies. I will back it out.

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

the patch is ready. i think the decision is not yet finalized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants