Skip to content

Conversation

@sudo-bmitch
Copy link
Contributor

Fixes issue

Fixes #855.

Describe the change

This adds a plus to the list of allowed path characters in an OCI Layout reference.

How to verify it

regctl image copy ocidir://output/regctl:scratch ocidir://test/path+with+plus:latest

Changelog text

  • Feat: Allow plus in ocidir path.

Please verify and check that the pull request fulfills the following requirements

  • Tests have been added or not applicable
  • Documentation has been added, updated, or not applicable
  • Changes have been rebased to main
  • Multiple commits to the same code have been squashed

Signed-off-by: Brandon Mitchell <git@bmitch.net>
@sudo-bmitch sudo-bmitch merged commit 2ed50db into regclient:main Nov 15, 2024
@sudo-bmitch sudo-bmitch deleted the pr-ref-path-allow-plus branch November 15, 2024 20:21
@sudo-bmitch sudo-bmitch added this to the v0.8.0 milestone Nov 15, 2024
@thesayyn
Copy link
Contributor

thesayyn commented Dec 5, 2024

Thanks for fixing this @sudo-bmitch

@mering
Copy link

mering commented Dec 9, 2024

@sudo-bmitch when do you plan to create a release including this PR? This is currently blocking bazel-contrib/rules_oci#738. Thanks.

@sudo-bmitch
Copy link
Contributor Author

It should be released this week. The last feature went in this weekend, and there's at least one bug fix remaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'+' is not allowed in reference paths

3 participants