Fix platform detection #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bitIsSet` function was returning the wrong value, forcing nodes to v1. This also adjusts the automatic appending of the variant to only happen when short values are provided. This avoids changing `linux/amd64` to `linux/amd64/vx` which would break existing users. Signed-off-by: Brandon Mitchell <git@bmitch.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Using
--platform localwas not detecting amd64 variants correctly.Describe the change
The
bitIsSetfunction was returning the wrong value, forcing nodes to v1. This also adjusts the automatic appending of the variant to only happen when short values are provided. This avoids changinglinux/amd64tolinux/amd64/vxwhich would break existing users.How to verify it
On an amd64 system that is at least v2:
regctl manifest get sudobmitch/demo:amd64-vx regctl image digest sudobmitch/demo:amd64-vx --platform localChangelog text
amd64variants for--platform local.Please verify and check that the pull request fulfills the following requirements
Tests are non-trivial to write for this since it is platform detection code that would run differently on different platforms.