Add NOINLINE pragma to mkFastWeakTicket #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Also move what I think is the corresponding comment) Without this NOINLINE, the FastWeakTicket can be fused away (in cacheSubscription in particular), causing early unsubscriptions. This manifested itself in reflex-dom-core as items in a nested list never being added to the DOM, because runWithReplace in the immediate builder was being unsubscribed from the lifted runWithReplace result events.
Member
|
Wow! |
Member
|
This also explains why debugging code would make the bug go away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Also move what I think is the corresponding comment)
Without this NOINLINE, the FastWeakTicket can be fused away (in
cacheSubscription in particular), causing early unsubscriptions.
This manifested itself in reflex-dom-core as items in a nested list
never being added to the DOM, because runWithReplace in the immediate
builder was being unsubscribed from the lifted runWithReplace result
events.