Skip to content

allow link as metatags #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adhami3310 merged 2 commits into from
Sep 25, 2024
Merged

allow link as metatags #3980

adhami3310 merged 2 commits into from
Sep 25, 2024

Conversation

@Lendemor
Copy link
Contributor

@Lendemor Lendemor commented Sep 24, 2024 •
edited
Loading

With this PR, we can now use SVG icon as favicon.

Example below:

favicon = rx.el.link(
    rel="icon",
    href="/cloud.svg",
    type="image/svg+xml",
)

@rx.page( meta=[favicon])
def index():
    return rx.text("Foo")

Closes #3887

masenf
masenf reviewed Sep 24, 2024
View reviewed changes
@adhami3310 adhami3310 merged commit 46be46d into main Sep 25, 2024
@masenf masenf deleted the lendemor/allow_link_as_metatags branch December 12, 2024 07:09
@dennisbakhuis dennisbakhuis mentioned this pull request Nov 30, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masenf masenf masenf left review comments

@adhami3310 adhami3310 adhami3310 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support SVG favicon

4 participants

@Lendemor @masenf @adhami3310