Skip to content

Cross-browser screenshots refactor#254

Merged
nwittwer merged 27 commits intodevfrom
@reflex/browser-installer
Jun 10, 2023
Merged

Cross-browser screenshots refactor#254
nwittwer merged 27 commits intodevfrom
@reflex/browser-installer

Conversation

@nwittwer
Copy link
Copy Markdown
Collaborator

@nwittwer nwittwer commented Jun 9, 2023

  • Removed need to use complicated custom separate browser installer code; instead use Playwright's CLI directly in the Electron process: e.g. playwright install webkit
  • Added basic tests to ensure packaged app has playwright-core module, and doesn't have .local-browsers at runtime. Browsers will be installed on first run.
  • Added RuntimeConfig
  • Added test to ensure final build directory is <500mb
  • Fixed incorrect scroll instead of wheel event in inject.js (WebPage)
  • Fixed blocking bug in inject script when no title is found
  • Improved UI for cross-browser screenshots

nwittwer added 27 commits June 6, 2023 11:38
…as the correct Playwright env variable configured
@nwittwer nwittwer merged commit f676b87 into dev Jun 10, 2023
@nwittwer nwittwer deleted the @reflex/browser-installer branch June 10, 2023 10:39
@nwittwer nwittwer linked an issue Jun 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Playwright screenshots & Worker

1 participant