[BUG] useForm Hook Allows external enabled to override Internal ID Check, Causing API calls with undefined ID #6867 #7031
Conversation
🦋 Changeset detectedLatest commit: 1ae1e9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi team 👋, |
…hub.com/DipakHalkude/refine into test/useform-queryoptions-enabled-tests Because I have not added the refinedev/core. So now I added that.
|
Hi team 👋, |
|
Now I deleted other 2 changeset and keep one which is for useForm tests. All changes are done: tests for useForm queryOptions.enabled behavior are added, branch is updated with main, and the changeset is properly added as a patch. Only one changeset is now present. The PR is ready for review — please let me know if any improvements are needed. Thank you! 🚀 |
|
Hi @BatuhanW 👋, I’ve opened this PR following the guidelines you shared. Could you please take a look and let me know your feedback? Thanks! 🙏 |
There was a problem hiding this comment.
If there are no changes in package dependencies, then there should be no changes in pnpm-lock.yaml.
pnpm i should solve this
There was a problem hiding this comment.
Ok. Wait I am on it :)
There was a problem hiding this comment.
@alicanerdurmaz Done, Please have a look :)
|
@alicanerdurmaz check now I guess the query you said is resolved now :) |
DipakHalkude
left a comment
There was a problem hiding this comment.
Restored @refinedev/rest in examples/data-provider-strapi-v4 and examples/refine-hr-ce
Ran pnpm i (allowed lockfile update) and committed normalized pnpm-lock.yaml
PR branch updated; ready for re-review.
There was a problem hiding this comment.
@alicanerdurmaz Done, Please have a look :)
|
Hey @DipakHalkude, thanks for improving Refine 🚀. We will merge this PR today. |
|
@alicanerdurmaz Thank you so much for reviewing and merging my PR! 🙏 I really appreciate your guidance and support throughout the process. Excited to continue contributing! 🚀 |
|
FYI @alicanerdurmaz this appears to have been a bot, see this and other repos attempted contributions happened to: vercel/turborepo#10796 |
|
Hi @spiceywasabi, just to clarify, that contribution was made by me personally and not a bot. I wanted to make sure there’s no confusion regarding my merged PRs. Thanks! |
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
What is the new behavior?
fixes (issue)
Notes for reviewers