click-outside-modal - New feature
#7169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Dec 17, 2023
Member
fregante
left a comment
There was a problem hiding this comment.
A bit hesitant to add this feature, but since it's so simple let's just do it.
Let's also make the name more generic just in case we want to extend it
readme.md
Outdated
| - [](# "same-branch-author-commits") [Preserves current branch and path when viewing all commits by an author.](https://user-images.githubusercontent.com/44045911/148764372-ee443213-e61a-4227-9219-0ee54ed832e8.png) | ||
| - [](# "easy-toggle-commit-messages") [Enables toggling commit messages by clicking on the commit box.](https://user-images.githubusercontent.com/1402241/152121837-ca13bf8a-9b7f-4517-8e8d-b58bb135523b.gif) | ||
| - [](# "link-to-compare-diff") [Linkifies the "X files changed" text on compare pages to allow jumping to the diff.](https://user-images.githubusercontent.com/46634000/157072587-0335357a-18c7-44c4-ae6e-237080fb36b4.png) | ||
| - [](# "checks-modal") [Closes checks list when clicking outside of modal.]() |
Member
There was a problem hiding this comment.
I meant the screenshot is not needed, but the mention in the readme yes
- [](# "checks-modal") Closes checks list when clicking outside of modal.
click-outside-modal
fregante
reviewed
Dec 17, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
^ squash followed by force push |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
I did it, thank you! |
Member
|
You can run |
fregante
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7157
Test URLs
Screenshot
// TODO