Skip to content

Mention pr-branch-auto-delete after branch deletion#5766

Merged
fregante merged 8 commits intomainfrom
auto-delete-banner
Jul 5, 2022
Merged

Mention pr-branch-auto-delete after branch deletion#5766
fregante merged 8 commits intomainfrom
auto-delete-banner

Conversation

@fregante
Copy link
Copy Markdown
Member

@fregante fregante commented Jul 3, 2022

Test URLs

Any open PR you can merge like #5742

Screenshot

Screen Shot 16

Demo

Note: The color and spacing has since been changed. Refer to the screenshot above

Screen.Recording.mov

Comment thread source/features/first-published-tag-for-merged-pr.tsx
observer.disconnect();
}
function getBanner(): JSX.Element {
const url = featureLink(features.getFeatureID(import.meta.url));
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links to pr-branch-auto-delete

Comment thread source/features/pr-branch-auto-delete.tsx Outdated
@fregante fregante marked this pull request as draft July 3, 2022 12:32
@fregante
Copy link
Copy Markdown
Member Author

fregante commented Jul 4, 2022

Well, this is a bit much:

Screen Shot 14

So I changed the style:

Screen Shot 18

@fregante fregante marked this pull request as ready for review July 4, 2022 01:42
@fregante fregante changed the title Add notice banner to pr-branch-auto-delete Mention pr-branch-auto-delete after branch deletion Jul 4, 2022
@fregante fregante merged commit b2bda4b into main Jul 5, 2022
@fregante fregante deleted the auto-delete-banner branch July 5, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

pr-branch-auto-delete should warn the user when it happens

1 participant