Skip to content

Use full width of the page#1172

Closed
adamzr wants to merge 1 commit intorefined-github:masterfrom
adamzr:patch-1
Closed

Use full width of the page#1172
adamzr wants to merge 1 commit intorefined-github:masterfrom
adamzr:patch-1

Conversation

@adamzr
Copy link
Copy Markdown

@adamzr adamzr commented Mar 15, 2018

Fixes #1171

@sindresorhus
Copy link
Copy Markdown
Member

Sorry, this is way too opinionated for Refined GitHub and it doesn't look very good either. Fill up the extra space by having two windows side-by-side ;)

Check out:

@fregante
Copy link
Copy Markdown
Member

way too opinionated for Refined GitHub

😅

@busches
Copy link
Copy Markdown
Member

busches commented Mar 15, 2018

I thought this sounded amazing, then I tried it and I had to uninstall it. I'll side with Sindre.

@adamzr
Copy link
Copy Markdown
Author

adamzr commented Mar 15, 2018

No problem. Thanks for considering it.

And thanks @sindresorhus for those other options, I'll try them.

Maybe 90% is not the right width for everyone, but I still think there are better width options than the one they chose. Maybe we could create multiple media queries for different size screens and choose a reasonable size for each width?

@sindresorhus
Copy link
Copy Markdown
Member

sindresorhus commented Mar 15, 2018

I think what GitHub has now is a good width. Whitespace can be important for usability. You don't always need to fill every empty space. And margins are important for readability. Reading text on something wider than 1000px becomes uncomfortable. They do use the fullwidth when it matters, for diffs and merge conflict resolving.

@sindresorhus
Copy link
Copy Markdown
Member

sindresorhus commented Mar 15, 2018

@bfred-it Would it make sense for us to just provide a text box in the settings where people can add their own CSS? Yes, they could use Stylish/etc, but it might be too much just to tweak a couple of things. Seems like an easy thing to do and then we can just point to that when there are requests we don't want.

@fregante fregante closed this Mar 16, 2018
@fregante
Copy link
Copy Markdown
Member

Closing for unpopularity.

@sindresorhus 👌

@andybergon
Copy link
Copy Markdown

You can use github-wide css in the refined-github CSS box.

I agree that it is pretty ugly to have a so stretched UI but just making that enabled by a button and not by default can be interesting as sometimes you have to read a code with lines longer than 120 characters.

@busches busches mentioned this pull request Jul 3, 2018
@jtagcat
Copy link
Copy Markdown
Contributor

jtagcat commented Mar 30, 2021

Necro

To add to the list of alternatives, https://github.com/fabiocchetti/wide-github

On a Thinkpad X230, with a small screen (and HD screens, FHD mod available). In this context, this is accessibility. It's a bit uglier, but more usable.

Does ref gh only add features, that are defaulted to enabled, or is there room for disabled-by-default changes as well?

Why not 'just use' the other user scripts and add-ons? Trust,… that it doesn't change over time. Without inspecting, initial risk is lower as well. Meaningless performance arguments (when running god damn too many add-ons) could be made as well.

@yakov116
Copy link
Copy Markdown
Member

Does ref gh only add features, that are defaulted to enabled, or is there room for disabled-by-default changes as well?

No see #2960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants